Comments on: [Rails] Cleaning up HABTM views (2/2)

By: steven

steven — Mon, 17 Aug 2009 02:48:51 +0000

I think that the right place to put that logic would be in the model.

I generally consider the model the right place to do any database cross-connection or binding. Similarly, I consider the controller the right place to either process data before the model is updated into the DB or the right place to treat data before shared with the view.

I think you might like the Programmatic screencast about advanced forms in Rails done by Ryan Bates. It covers better form modeling technique including controller vs. model issues.

By: T Tally

T Tally — Fri, 14 Aug 2009 17:38:50 +0000

Great tutorial but I have one question. Has anyone tried to create records with a HABTM relationship within the View? If so is it best to place that code within the controller or the model?

By: Peter Hoeg

Peter Hoeg — Tue, 16 Dec 2008 06:28:25 +0000

Just a quick comment. Your flavorstring can be boiled down from:

def flavorstring
if (self.flavors.length > 0)
x=String.new()
self.flavors.uniq.each do |f|
x += f.name
x += “, ”
end
return x.sub(/,s+$/,”)
else
return “”
end
end

to:

def flavorstring
return self.flavors.uniq.join(‘, ‘)
end

Flavors really never should be nil but if you insist on checking you can modify it to:

return self.flavors ? self.flavors.uniq.join.(‘, ‘) : ”